build: link against swiftOnoneSupport in debug configuration #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building debug, swift requires a supplementary library. The swift driver is aware of this and will make the appropriate arrangements. However, since the swift component is compacted into the C library, the linker driver being used does not understand this requirement. Explicitly link against the support library. This allows building the debug configuration of libdispatch with a release configuration of the swift standard library.
|
CC: @MadCoder |
|
@swift-ci please test |
|
@MadCoder ping |
ktopley-apple
approved these changes
Aug 20, 2018
|
@compnerd This commit caused failures on the LSAN bot. https://ci.swift.org/job/oss-swift-incremental-RA-lsan-linux-ubuntu-16_10/4863 The failures look like false positives to me: Memory leaks in SIL instructions should have been caught earlier during building the Swift dylib and overlays. |
|
@compnerd Actually, I was wrong. We have known leaks in the sanitizer. This change just caused libdispatch to be build optimized instead of in a debug configuration and now we see those leaks. |
|
That should have read: "We have known leaks in the optimizer." |
ktopley-apple
added a commit
that referenced
this pull request
Dec 6, 2018
build: link against swiftOnoneSupport in debug configuration Signed-off-by: Kim Topley <ktopley@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building debug, swift requires a supplementary library. The swift driver
is aware of this and will make the appropriate arrangements. However, since the
swift component is compacted into the C library, the linker driver being used
does not understand this requirement. Explicitly link against the support
library. This allows building the debug configuration of libdispatch with a
release configuration of the swift standard library.